Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8325094

JDWP: Some header files seem to rely on transitive includes

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: P5 P5
    • tbd
    • 23
    • core-svc
    • None

      During the review of the fix for https://bugs.openjdk.org/browse/JDK-8324668, in the PR, there was a suggestion that one of the include statements in a c file be reordered https://github.com/openjdk/jdk/pull/17588#discussion_r1472358835.

      However, reordering that include, causes compilation failures as noted in the subsequent comment there. Specifically, that leads to:

      In file included from /jdk/src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c:33:
      /jdk/src/jdk.jdwp.agent/share/native/libjdwp/error_messages.h:35:20: error: unknown type name 'FILE'
      void print_message(FILE *fp, const char *prefix, const char *suffix,
                         ^
      /jdk/src/jdk.jdwp.agent/share/native/libjdwp/error_messages.h:41:29: error: a parameter list without types is only allowed in a function definition
      const char * jvmtiErrorText(jvmtiError);
                                  ^
      /jdk/src/jdk.jdwp.agent/share/native/libjdwp/error_messages.h:43:28: error: a parameter list without types is only allowed in a function definition
      const char * jdwpErrorText(jdwpError);
                                 ^
      3 errors generated.

      I think this is because some of these header files aren't explicitly listing the necessary includes for some of the types they use.

            Unassigned Unassigned
            jpai Jaikiran Pai
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: