Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8325179

Race in BasicDirectoryModel.validateFileCache

    XMLWordPrintable

Details

    • b19
    • 15
    • b16

    Backports

      Description

        BasicDirectoryModel.validateFileCache starts a background thread, a FilesLoader object, to update the list of files in the current directory.

        First, the method checks if there's an existing filesLoader and interrupts it.

        Then it creates a new filesLoader.

        The above is done without any synchronisation, which means if the method is called concurrently by several threads, several fileLoader threads could be started concurrently. If it happens, only the latest one may be interrupted.

        A similar problem exists in invalidateFileCache, access to filesLoader field isn't protected by a lock.


        BasicDirectoryModel.FilesLoader.cancelRunnables has a data race too. The 'runnable' field is a volatile field, but it's not enough.

        It is possible that runnable is not null when the condition is checked but becomes null in the body of the if statement. It could be set a new value too.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8331324 Race in BasicDirectoryModel.validateFileCache

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8331482 Race in BasicDirectoryModel.validateFileCache

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8333253 Race in BasicDirectoryModel.validateFileCache

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8333285 Race in BasicDirectoryModel.validateFileCache

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8333415 Race in BasicDirectoryModel.validateFileCache

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8333534 Race in BasicDirectoryModel.validateFileCache

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8334000 Race in BasicDirectoryModel.validateFileCache

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8334311 Race in BasicDirectoryModel.validateFileCache

            • P3 - Major loss of function.
            • Resolved
            duplicates

            Bug - A problem which impairs or prevents the functions of the product. JDK-8332000 BasicDirectoryModel/ConcurrentModification.java fails with Out of Memory

            • P3 - Major loss of function.
            • Closed
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8238169 BasicDirectoryModel getDirectories and DoChangeContents.run can deadlock

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Bug - A problem which impairs or prevents the functions of the product. JDK-8331142 Add test for number of loader threads in BasicDirectoryModel

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Bug - A problem which impairs or prevents the functions of the product. JDK-8240690 Race condition between EDT and BasicDirectoryModel.FilesLoader.run0()

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Bug - A problem which impairs or prevents the functions of the product. JDK-8323670 A few client tests intermittently throw ConcurrentModificationException

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Bug - A problem which impairs or prevents the functions of the product. JDK-8307091 A few client tests intermittently throw ConcurrentModificationException

            • P2 - Crashes, loss of data, severe memory leak.
            • Closed
            links to

            Commit Commit openjdk/jdk11u-dev/2e4179b9

            Commit Commit openjdk/jdk17u-dev/bc5639a8

            Commit Commit openjdk/jdk21u-dev/4b3df73b

            Commit Commit openjdk/jdk22u/e6ba0ee4

            Commit Commit openjdk/jdk/e66788c1

            Review Review openjdk/jdk11u-dev/2768

            Review Review openjdk/jdk17u-dev/2539

            Review Review openjdk/jdk17u-dev/2558

            Review Review openjdk/jdk21u-dev/633

            Review Review openjdk/jdk22u/164

            Review Review openjdk/jdk/18111

            Activity

              People

                aivanov Alexey Ivanov
                aivanov Alexey Ivanov
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: