Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8325490

gtest LogSelectionList::combination_limit Running out of LogTagSet

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Duplicate
    • Icon: P4 P4
    • tbd
    • None
    • hotspot

      The gtest `LogSelectionList::combination_limit` asserts that
      `LogTagSet::ntagsets() < LogSelectionList::MaxSelections`.

      On at least linux-x64-debug this is triggered if a single new LogTagSet is added.

      The normal `linux-x64-debug` java binary uses 244 LogTagSets, the gtestLauncher adds an additional 11 LogTagSets brining the total to 255 which is just on the limit.

      This test was added in JDK-8153731 when the MaxSelections was bumped to 256. It is unclear if limiting the LogTagSet number by the available LogTagSelections is correct.

      It does at least warrant some investigation. Should the test be removed or is there some technical reason for limiting the used LogTagSets to the number of LogTagSelections?

      The following are exclusively used by the gtest;
      ```
      gc+class
      gc+safepoint+logging
      logging+class
      logging+gc
      logging+gc+class
      logging+gc+class+safepoint+heap
      logging+safepoint
      logging+safepoint+jni
      logging+test
      safepoint+class
      test
      ```

            rschmelter Ralf Schmelter
            aboldtch Axel Boldt-Christmas
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: