Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8325672

C2: allocate PhaseIdealLoop::_loop_or_ctrl from C->comp_arena()

    XMLWordPrintable

Details

    • b25
    • 21
    • b10

    Backports

      Description

        If we don't do that, then this array is ResourceArea allocated. That means we can get in trouble with ResourceMarks inside the PhaseIdealLoop. If the array is updated because of new nodes, and this grows the area in a ResourceMark scope, then the data behind _loop_or_ctrl becomes invalid, and we get use-after-free memory corruption bugs.

        The array was added in JDK-8302670, hence this is a fix to that regression. We should backport down to JDK21.

        I don't yet have a reproducer. But this triggered with my patch for JDK-8325589.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8326134 C2: allocate PhaseIdealLoop::_loop_or_ctrl from C->comp_arena()

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8326504 C2: allocate PhaseIdealLoop::_loop_or_ctrl from C->comp_arena()

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8327193 C2: allocate PhaseIdealLoop::_loop_or_ctrl from C->comp_arena()

            • P3 - Major loss of function.
            • Resolved
            relates to

            Enhancement - null JDK-8337015 Revisit resource arena allocations in C2

            • P2 - Crashes, loss of data, severe memory leak.
            • Open

            Bug - A problem which impairs or prevents the functions of the product. JDK-8302670 use-after-free related to PhaseIterGVN interaction with Unique_Node_List and Node_Stack

            • P3 - Major loss of function.
            • Resolved
            links to

            Commit Commit openjdk/jdk21u-dev/93be33ca

            Commit Commit openjdk/jdk22u/78df8c1e

            Commit Commit openjdk/jdk/74b90aa8

            Review Review openjdk/jdk21u-dev/261

            Review Review openjdk/jdk22u/72

            Review Review openjdk/jdk/17814

            Activity

              People

                epeter Emanuel Peter
                epeter Emanuel Peter
                Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: