-
Bug
-
Resolution: Fixed
-
P5
-
22
-
b21
-
b15
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8337467 | 21.0.6-oracle | Srinivas Mandalika | P5 | Resolved | Fixed | b01 |
JDK-8343348 | 21.0.6 | Goetz Lindenmaier | P5 | Resolved | Fixed | b02 |
JDK-8337850 | 17.0.14-oracle | Srinivas Mandalika | P5 | Resolved | Fixed | b01 |
JDK-8343355 | 17.0.14 | Goetz Lindenmaier | P5 | Resolved | Fixed | b02 |
JDK-8337973 | 11.0.26-oracle | Srinivas Mandalika | P5 | Resolved | Fixed | b01 |
JDK-8338804 | 8u441 | Srinivas Mandalika | P5 | Resolved | Fixed | b01 |
The Builder class is public and has public constructor. At the same time, a better design would be to hide all the Builder constructors and rely on the builder() method which returns an instance of the Builder.
At the same time, the builder() helper wasn't available until
For this reason, there are 20 tests which create the PassFailJFrame.Builder object using its constructor instead of the helper method. These tests have to be updated.
To find these tests, run:
grep -r 'new PassFailJFrame.Builder' test/jdk
Hiding the PassFailJFrame.Builder constructor is a better design choice. New tests should not create the builder using the `new` keyword. To enforce it, the Builder constructor needs to be private.
- backported by
-
JDK-8337467 Hide PassFailJFrame.Builder constructor
- Resolved
-
JDK-8337850 Hide PassFailJFrame.Builder constructor
- Resolved
-
JDK-8337973 Hide PassFailJFrame.Builder constructor
- Resolved
-
JDK-8338804 Hide PassFailJFrame.Builder constructor
- Resolved
-
JDK-8343348 Hide PassFailJFrame.Builder constructor
- Resolved
-
JDK-8343355 Hide PassFailJFrame.Builder constructor
- Resolved
- relates to
-
JDK-8338571 [TestBug] DefaultCloseOperation.java test not working as expected wrt instruction after JDK-8325851 fix
- In Progress
-
JDK-8293830 ☂ Redesign Manual Test Framework
- Open
-
JDK-8294156 Allow PassFailJFrame.Builder to create test UI
- Resolved
-
JDK-8294535 Add screen capture functionality to PassFailJFrame
- Resolved
- links to
-
Commit openjdk/jdk/3b9255eb
-
Commit(master) openjdk/jdk17u-dev/0494928e
-
Commit(master) openjdk/jdk21u-dev/86a7babb
-
Review openjdk/jdk/18206
-
Review(master) openjdk/jdk17u-dev/3014
-
Review(master) openjdk/jdk21u-dev/1107