Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8327138

Clean up status management in cdsConfig.hpp and CDS.java

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P4
    • 23
    • None
    • hotspot
    • b14

    Description

      https://github.com/openjdk/jdk/blob/b38a6c5780611f02d02215c65340b725e4c18929/src/hotspot/share/cds/cdsConfig.hpp
      https://github.com/openjdk/jdk/blob/b38a6c5780611f02d02215c65340b725e4c18929/src/java.base/share/classes/jdk/internal/misc/CDS.java

      A few clean ups:

      [1] Rename functions like "is_loading_full_module_graph()" to "is_using_full_module_graph()". The meaning of "loading" is not clear: it might be interpreted as to cover only the period where the artifact is being loaded, but not the period after the artifact is completely loaded. However, the function is meant to cover both periods, so "using" is a more precise term.

      Similarly, the cumbersome sounding "disable_loading_full_module_graph()" is changed to "stop_using_full_module_graph()", etc.

      [2] The status of is_using_optimized_module_handling() is moved from metaspaceShared.hpp to cdsConfig.hpp, to be consolidated with other types of CDS status.

      [3] The status of CDS was communicated to the Java class jdk.internal.misc.CDS by ad-hoc native methods. This is now changed to a single method, CDS.getCDSConfigStatus() that returns a bit field. That way we don't need to add a new native method for each type of status.

      [4] CDS.isDumpingClassList() was a misnomer. It's changed to CDS.isLoggingLambdaFormInvokers().

      Attachments

        Issue Links

          Activity

            People

              iklam Ioi Lam
              iklam Ioi Lam
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: