-
Enhancement
-
Resolution: Fixed
-
P5
-
None
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8346207 | 21.0.7-oracle | Deepak Damodaran | P5 | Resolved | Fixed | b01 |
JDK-8347587 | 21.0.7 | Goetz Lindenmaier | P5 | Resolved | Fixed | b01 |
JDK-8346318 | 17.0.15-oracle | Deepak Damodaran | P5 | Resolved | Fixed | b01 |
The code in test/jdk/java/foreign/CallGeneratorHelper used to generate native test libraries is out of date. There are several issues:
- We no longer generate header files, so the code for that is dead
- The code was never updated to generate the *Stack.c test files
- The code was never updated to generate the shared.h file
The native test libraries that are generated closely correspond to the test cases that are generated by the actual TestNG tests (the former uses the same DataProvier as the latter). So, I think it is worthwhile to keep around/update the native test file generation code, in case we ever need to tweak the test case generation logic (which would then require re-generating the native test files).
- We no longer generate header files, so the code for that is dead
- The code was never updated to generate the *Stack.c test files
- The code was never updated to generate the shared.h file
The native test libraries that are generated closely correspond to the test cases that are generated by the actual TestNG tests (the former uses the same DataProvier as the latter). So, I think it is worthwhile to keep around/update the native test file generation code, in case we ever need to tweak the test case generation logic (which would then require re-generating the native test files).
- backported by
-
JDK-8346207 Update code gen in CallGeneratorHelper
-
- Resolved
-
-
JDK-8346318 Update code gen in CallGeneratorHelper
-
- Resolved
-
-
JDK-8347587 Update code gen in CallGeneratorHelper
-
- Resolved
-
- links to
-
Commit openjdk/jdk/ac2f8e5a
-
Commit(master) openjdk/jdk21u-dev/be0da80a
-
Review openjdk/jdk/18269
-
Review(master) openjdk/jdk21u-dev/1315
(2 links to)