-
Bug
-
Resolution: Fixed
-
P4
-
11, 17, 21, 23
-
b16
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8329695 | 21.0.4-oracle | Alexey Ivanov | P4 | Resolved | Fixed | b04 |
JDK-8330831 | 21.0.4 | Goetz Lindenmaier | P4 | Resolved | Fixed | b01 |
java/awt/Dialog/DialogAnotherThread/JaWSTest.java is a closed test.
For no reason other than it has never been opened.
On hidpi with fractional scales this test can fail because it clicks on the x/y location of the button rather than somewhere safely in the middle of the button
The minimal fix is therefore
Point buttonLocation = button.getLocationOnScreen();
- robot.mouseMove(buttonLocation.x, buttonLocation.y);
+ robot.mouseMove(buttonLocation.x + button.getWidth()/2,
+ buttonLocation.y + button.getHeight()/2);
But this test is also written as an Applet so it should be reworked as a main program.
In fact because of the above problem the test is problem listed because of that (JDK-8238720)
Yet it is seen failing on Windows HiDPI because there's a bug in the problem list - it is listed twice - once for this bug and once for JDK-8324782 - a macOS issue.
So the macOS one happens to be the one that gets used by jtreg and the windows one is missed.
However the test even when fixed needs to remain problem listed on macOS because it fails for different reasons (see JDK-8324782) on macOS14.
So the macOS problem listing will need to move to open along with the test
even if the windows one is removed.
Because JDK-8238720 is used to problem list a number of tests, we will need a new bug id to fix + open this test.
For no reason other than it has never been opened.
On hidpi with fractional scales this test can fail because it clicks on the x/y location of the button rather than somewhere safely in the middle of the button
The minimal fix is therefore
Point buttonLocation = button.getLocationOnScreen();
- robot.mouseMove(buttonLocation.x, buttonLocation.y);
+ robot.mouseMove(buttonLocation.x + button.getWidth()/2,
+ buttonLocation.y + button.getHeight()/2);
But this test is also written as an Applet so it should be reworked as a main program.
In fact because of the above problem the test is problem listed because of that (JDK-8238720)
Yet it is seen failing on Windows HiDPI because there's a bug in the problem list - it is listed twice - once for this bug and once for JDK-8324782 - a macOS issue.
So the macOS one happens to be the one that gets used by jtreg and the windows one is missed.
However the test even when fixed needs to remain problem listed on macOS because it fails for different reasons (see JDK-8324782) on macOS14.
So the macOS problem listing will need to move to open along with the test
even if the windows one is removed.
Because JDK-8238720 is used to problem list a number of tests, we will need a new bug id to fix + open this test.
- backported by
-
JDK-8329695 hidpi problems for test java/awt/Dialog/DialogAnotherThread/JaWSTest.java
- Resolved
-
JDK-8330831 hidpi problems for test java/awt/Dialog/DialogAnotherThread/JaWSTest.java
- Resolved
- relates to
-
JDK-8329769 Remove closed java/awt/Dialog/DialogAnotherThread/JaWSTest.java
- Resolved
- links to
-
Commit openjdk/jdk21u-dev/62993e7a
-
Commit openjdk/jdk/23ebd9c3
-
Review openjdk/jdk21u-dev/513
-
Review openjdk/jdk/18438
-
Review openjdk/jdk/18439
(3 links to)