Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8329213

Better validation for com.sun.security.ocsp.useget option

    XMLWordPrintable

Details

    Backports

      Description

        (Noticed this while doing JDK-8328638 backports)

        JDK-8328638 introduced a new boolean option, `com.sun.security.ocsp.useget`. We use the usual `Boolean.parseBoolean` to convert it from String to boolean value, which works correctly for `false` and `true` as boolean values. However, any string that is not `true` would be treated as `false`. Which means that if users mistype the value, they would not get the default behavior pre-JDK-8328638, but rather a fallback, non-default behavior.

        It would be preferable to validate the option range a bit better, and default to the correct value on any error.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8329684 Better validation for com.sun.security.ocsp.useget option

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8329686 Better validation for com.sun.security.ocsp.useget option

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8329799 Better validation for com.sun.security.ocsp.useget option

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            relates to

            Enhancement - null JDK-8328638 Fallback option for POST-only OCSP requests

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk17u-dev/533fac61

            Commit Commit openjdk/jdk21u-dev/fbc5871c

            Commit Commit openjdk/jdk22u/8d7d8a49

            Commit Commit openjdk/jdk/4a14cba2

            Review Review openjdk/jdk17u-dev/2338

            Review Review openjdk/jdk21u-dev/413

            Review Review openjdk/jdk22u/121

            Review Review openjdk/jdk/18525

            Activity

              People

                shade Aleksey Shipilev
                shade Aleksey Shipilev
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: