Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8329470

Remove obsolete CDS SharedStrings tests

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P4
    • 23
    • None
    • hotspot
    • b17

    Description

      These tests are quite time consuming. Removing them will speed up the CDS tests cycle.

      [1] The LockSharedStrings.java test is obsolete. The archived strings used to be in its own "special" G1 region and we needed a test to check if locking objects in this region is working properly. Today all archived heap objects are stored in regular G1 regions. This test is no longer needed.

      [2] This part of SharedStringsStress.java is no longer relevant and can be deleted.

      https://github.com/openjdk/jdk/blob/d3fc8df8af11d7cc1cc341bc75e46b7e93d6db31/test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/SharedStringsStress.java#L76-L85

      // Test for handling of heap fragmentation. With sharedArchiveConfigFile, we will dump about
      // 18MB of shared objects on 64 bit VM (smaller on 32-bit).
      //
      // During dump time, an extra copy of these objects are allocated,
      // so we need about 36MB, plus a few MB for other system data. So 64MB total heap
      // should be enough.
      //
      // The VM should executed a full GC to maximize contiguous free space and
      // avoid fragmentation.
      {"-Xmx64m"},

      During CDS dump time, we no longer allocate extra copies of the archived heap objects in the actual Java heap.

      Attachments

        Issue Links

          Activity

            People

              iklam Ioi Lam
              iklam Ioi Lam
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: