Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8288981 C2: Fix issues with skeleton predicates
  3. JDK-8330386

Replace Opaque4Node of Initialized Assertion Predicate with new OpaqueInitializedAssertionPredicateNode

XMLWordPrintable

    • b25

      Currently, a Template Assertion Predicate and an Initialized Assertion Predicate both use an Opaque4 node. They could also both use a Halt Node on the uncommon proj. To distinguish them, one need to find the OpaqueLoop* nodes.

      To simplify that, I introduce a new OpaqueInitializedAssertionPredicate node for Initialized Assertion Predicates. An additional benefit compared to Opaque4 nodes is that we do not need a second input to store the constant that's gonna be used for product builds - we implicitly know that the check is always true and can later replace it with a true constant.

      I will not rename or refactor the usage of Opaque4 nodes here. I want to later replace the Template Assertion Predicate If nodes by a dedicated TemplateAssertionPredicateNode. Then we can get rid of the Opaque4 node for Assertion Predicates all together.

            chagedorn Christian Hagedorn
            chagedorn Christian Hagedorn
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: