Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8331432

Clean up comments in GenArguments::initialize_size_info()

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Unresolved
    • Icon: P4 P4
    • tbd
    • 23
    • hotspot
    • gc

      During JDK-8329223 code review (https://github.com/openjdk/jdk/pull/18539/)

      @lgxbslgx suggested some comment cleanup:

      ```
      The comment shown below seems strange. Can it be removed?

          // The generation minimums and the overall heap minimum should
          // be within one generation alignment.


      The warning message shown below can be more consistent with this newly added one.

            log_warning(gc, ergo)("Inconsistency between maximum heap size and maximum "
                                  "generation sizes: using maximum heap = " SIZE_FORMAT
                                  ", -XX:OldSize flag is being ignored",
                                  MaxHeapSize);

      ```

            Unassigned Unassigned
            zgu Zhengyu Gu
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: