| Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
|---|---|---|---|---|---|---|
| JDK-8338987 | 8u441 | Ambarish Rapte | P4 | Resolved | Fixed | b01 |
Code inspection has revealed cleanup items in the native getRGBImpl and setRGBImpl methods of com.sun.pisces.AbstractSurface (in JAbstractSurface.c).
There is a missing check for "offset < 0" that should be added to the list of checks near the beginning of the two methods. The Java side already checks for this case before calling the native method, but should be checked in the native code as well. Additionally, dstX and dstY in getRGBImpl, and srcX and srcY in setRGBImpl should be changed to "const" variables, since we rely on them being non-negative.
There is a missing check for "offset < 0" that should be added to the list of checks near the beginning of the two methods. The Java side already checks for this case before calling the native method, but should be checked in the native code as well. Additionally, dstX and dstY in getRGBImpl, and srcX and srcY in setRGBImpl should be changed to "const" variables, since we rely on them being non-negative.
- backported by
-
JDK-8338987 Cleanup native AbstractSurface methods getRGBImpl, setRGBImpl
-
- Resolved
-
- blocks
-
JDK-8335879 Remove unused vars from native AbstractSurface methods getRGBImpl, setRGBImpl
-
- Open
-
- links to
-
Commit(master)
openjdk/jfx/e0fdb42b
-
Review(master)
openjdk/jfx/1497