Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8332313

Update code review guidelines

XMLWordPrintable

    • b19

      The JavaFX CONTRIBUTING guidelines [1] includes guidance for creating, reviewing, and integrating changes to JavaFX, along with a pointer to a Code Review policies Wiki page [2].

      We would like to update these guidelines to improve the quality of reviews, with a goal of improving JavaFX and decreasing the chance of introducing a serious regression or other critical bug.

      We will first convert the Code Review Policies Wiki [2] page to a "README-code-reviews.md" file in the repo, and then update the Reviewers section with additional guidelines that "R"eviewers should keep in mind when reviewing, and Committers should be aware of before integrating or sponsoring a PR.

      We will update the CONTRIBUTING.md page to point to the "README-code-reviews.md", highlighting important requirements as needed.

      [1] https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md
      [2] https://wiki.openjdk.org/display/OpenJFX/Code+Reviews

            kcr Kevin Rushforth
            kcr Kevin Rushforth
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: