Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8332442

C2: refactor Mod cases in Compile::final_graph_reshaping_main_switch()

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P4
    • 24
    • 23
    • hotspot
    • b16

    Description

      Op_ModI/Op_ModL/Op_UModI/Op_UModL cases are almost identical and could be refactored to a single one possibly using MulNode::make() and new similar helper methods.

      If there's no IR test that verifies this transformation, it would be nice to add some to verify the refactoring doesn't break anything.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. JDK-8341068 [s390x] compiler/c2/TestDivModNodes.java Failure

          • P3 - Major loss of function.
          • Open
          links to

          Commit Commit(master) openjdk/jdk/10050a72

          Review Review(master) openjdk/jdk/20877

          Activity

            People

              kxu Kangcheng Xu
              roland Roland Westrelin
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: