Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8334322

Misleading values of keys in jpackage resource bundle

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: P4 P4
    • None
    • None
    • tools
    • None
    • generic
    • generic

      Values of "error.invalid-value-for-package-name" and "error.invalid-value-for-package-name.advice" in [1] are misleading. They used to report errors when an invalid rpm or deb package name is passed on jpackage command line. But they refer to Debian packaging and mention the nonexistent "linux-bundle-name" jpackage CLI option.

      The keys must be split in two: one pair for rpm:

      "error.rpm-invalid-value-for-package-name"
      "error.rpm-invalid-value-for-package-name.advice"

      and one for deb packages:

      "error.deb-invalid-value-for-package-name"
      "error.deb-invalid-value-for-package-name.advice"

      with the text values adjusted accordingly.

      A corresponding jtreg test must be added.

      [1] https://github.com/openjdk/jdk/blob/8464ce6db5cbd5d50ac2a2bcba905b7255f510f5/src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/LinuxResources.properties#L49

            asemenyuk Alexey Semenyuk
            asemenyuk Alexey Semenyuk
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: