-
Bug
-
Resolution: Fixed
-
P4
-
22, 23, 24
-
b04
-
generic
-
generic
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8334959 | 23.0.1 | Hannes Greule | P4 | Resolved | Fixed | b02 |
JDK-8334819 | 23 | Hannes Greule | P4 | Closed | Fixed | b29 |
I found two problems in the FFM javadocs:
1. Linker: https://github.com/openjdk/jdk/blob/880e458a1072589ae199cc9204dcce9eab0f4eaa/src/java.base/share/classes/java/lang/foreign/Linker.java#L225 the padding is wrong, it should be 4 instead.
2. MemoryLayout: https://github.com/openjdk/jdk/blob/880e458a1072589ae199cc9204dcce9eab0f4eaa/src/java.base/share/classes/java/lang/foreign/MemoryLayout.java#L372 segment is not defined before, it's supposed to reference the points variable.
I also noticed that wrong paddingLayout usage in the Snippets file (https://github.com/openjdk/jdk/blob/bdd96604ae55ba0cd3cd3363e2ba44205d8aa3aa/src/java.base/share/classes/java/lang/foreign/snippet-files/Snippets.java#L338) but those seem to be unused. Maybe they should be removed?
1. Linker: https://github.com/openjdk/jdk/blob/880e458a1072589ae199cc9204dcce9eab0f4eaa/src/java.base/share/classes/java/lang/foreign/Linker.java#L225 the padding is wrong, it should be 4 instead.
2. MemoryLayout: https://github.com/openjdk/jdk/blob/880e458a1072589ae199cc9204dcce9eab0f4eaa/src/java.base/share/classes/java/lang/foreign/MemoryLayout.java#L372 segment is not defined before, it's supposed to reference the points variable.
I also noticed that wrong paddingLayout usage in the Snippets file (https://github.com/openjdk/jdk/blob/bdd96604ae55ba0cd3cd3363e2ba44205d8aa3aa/src/java.base/share/classes/java/lang/foreign/snippet-files/Snippets.java#L338) but those seem to be unused. Maybe they should be removed?
- backported by
-
JDK-8334959 FFM: two javadoc problems
- Resolved
-
JDK-8334819 FFM: two javadoc problems
- Closed
- links to
-
Commit openjdk/jdk/3edf379b
-
Commit openjdk/jdk/72ca7baf
-
Review openjdk/jdk/19820
-
Review openjdk/jdk/19846
(1 links to)