-
Enhancement
-
Resolution: Unresolved
-
P4
-
None
-
None
-
None
The PR review of JDK-8321274 noted that there is room for clarification in the comments and processing of the 'external file attributes' field for Unix-compatible files:
* The ZipEntry.externalFileAttributes field comment could be updated to reflect that this field only holds data for Unix-compatible entries.
* In ZipFile.getZipEntry, the comment could be updated to reflect that all 16 Unix-relevant bits are read
* In ZipFile.getZipEntry, there is no longer any need to mask the bits read with 0xFFFF
* ZipUtils.CENATX_PERMS no longer reads just permissions, this method could be renamed to CENATX_UNIX.
* The ZipEntry.externalFileAttributes field comment could be updated to reflect that this field only holds data for Unix-compatible entries.
* In ZipFile.getZipEntry, the comment could be updated to reflect that all 16 Unix-relevant bits are read
* In ZipFile.getZipEntry, there is no longer any need to mask the bits read with 0xFFFF
* ZipUtils.CENATX_PERMS no longer reads just permissions, this method could be renamed to CENATX_UNIX.
- relates to
-
JDK-8321274 Rename ZipEntry.extraAttributes to ZipEntry.externalFileAttributes
- Resolved