Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8335795

Clarify comments related to ZipEntry.externalFileAttributes

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Unresolved
    • Icon: P4 P4
    • None
    • None
    • core-libs
    • None

      The PR review of JDK-8321274 noted that there is room for clarification in the comments and processing of the 'external file attributes' field for Unix-compatible files:

      * The ZipEntry.externalFileAttributes field comment could be updated to reflect that this field only holds data for Unix-compatible entries.
      * In ZipFile.getZipEntry, the comment could be updated to reflect that all 16 Unix-relevant bits are read
      * In ZipFile.getZipEntry, there is no longer any need to mask the bits read with 0xFFFF
      * ZipUtils.CENATX_PERMS no longer reads just permissions, this method could be renamed to CENATX_UNIX.


            eirbjo Eirik Bjørsnøs
            eirbjo Eirik Bjørsnøs
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: