Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8338809

[IR Framework] Make matches on single C2 IR nodes with IRNode class exact to avoid mismatches with shared substrings

XMLWordPrintable

      Some C2 nodes share the same substrings. For example: CmpU/CmpU3 or CountedLoop/Loop. We've encountered some problems in the past that matching rules failed because an IR test relied on the uniqueness of an IRNode.XYZ match which was not the case (see https://github.com/openjdk/jdk/pull/18198#issuecomment-2214675206 as an example).

      We therefore propose to update all default entries in the IRNode class to use a unique regex that only matches the node name. If some IR rules relied on the sharing feature, we should either update the rules or provide a new default entry as for example IRNode.MUL which covers "Mul(I|L|F|D)".

            Unassigned Unassigned
            chagedorn Christian Hagedorn
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: