Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8340007

Refactor KeyEvent/FunctionKeyTest.java

XMLWordPrintable

    • b17
    • 22
    • b17

        The java/awt/event/KeyEvent/FunctionKeyTest.java test can be improved:

        The class FunctionKeyTester should be moved into FunctionKeyTest;
        The constants in switch statement 403, 404 should be replaced with KEY_PRESSED and KEY_RELEASED which are more descriptive;
        The `failures` field is of type StringBuilder which is not thread-safe, but it's accessed from two threads.

              aivanov Alexey Ivanov
              aivanov Alexey Ivanov
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Created:
                Updated:
                Resolved: