Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8341142

Maintain a single source file for sun.net.www.protocol.jar.JarFileFactory

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 24
    • None
    • core-libs
    • b20

      Right now, the source for sun.net.www.protocol.jar.JarFileFactory is maintained in OS specific locations of the JDK repo:

      Unix: src/java.base/unix/classes/sun/net/www/protocol/jar/JarFileFactory.java
      Windows: src/java.base/windows/classes/sun/net/www/protocol/jar/JarFileFactory.java

      Looking at the difference in these files, the only difference is a mere additional method (and usage of that method) on Windows. Instead of keeping two separate files with all the duplicate code, it would be easier to just move the source to "share/classes" and implement a conditional check for additional logic on Windows OS.

      The entire side-by-side diff of these 2 files is attached for reference.

            jpai Jaikiran Pai
            jpai Jaikiran Pai
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: