When JDK-8305895 is integrated, there will be two more CDS archives built by default as part of the build called classes_coh.jsa and classes_nocoops_coh.jsa.
These shared archives should be removed so that 30 million users do not download these extra bytes that they will not be using.
The OpenJDK default for building archives will be changed to not build these by default so that we are not testing code we're not shipping. Other vendors are free to change the default for their testing and deployment. [~rkennke]
After changing the default we need to:
1. Fix the tests to not fail when -XX:+UseCompactObjectHeaders is on that assume that there's a default archive present.
2. Add to the release notes instructions how to build the CDS archives locally if using -XX:+UseCompactObjectHeaders.
3. Maybe add a warning that the CDS archive isn't present with -XX:+UseCompactObjectHeaders (tbd).
Most CDS tests don't require having a default archive and build a local archive as part of the testing so CDS testing will still be covered with -XX:+UseCompactObjectHeaders. Experimentally we found that there's only around 6 tests that need to be adjusted with this change.
These shared archives should be removed so that 30 million users do not download these extra bytes that they will not be using.
The OpenJDK default for building archives will be changed to not build these by default so that we are not testing code we're not shipping. Other vendors are free to change the default for their testing and deployment. [~rkennke]
After changing the default we need to:
1. Fix the tests to not fail when -XX:+UseCompactObjectHeaders is on that assume that there's a default archive present.
2. Add to the release notes instructions how to build the CDS archives locally if using -XX:+UseCompactObjectHeaders.
3. Maybe add a warning that the CDS archive isn't present with -XX:+UseCompactObjectHeaders (tbd).
Most CDS tests don't require having a default archive and build a local archive as part of the testing so CDS testing will still be covered with -XX:+UseCompactObjectHeaders. Experimentally we found that there's only around 6 tests that need to be adjusted with this change.
- relates to
-
JDK-8344821 Test CheckDefaultArchiveFile.java fails if classes_coh.jsa is not present
-
- Resolved
-
-
JDK-8350457 Support Compact Object Headers as product option
-
- Open
-
-
JDK-8344844 ciReplay tests fail with -XX:+UseCompactObjectHeaders because CDS is disabled since JDK-8341553
-
- Resolved
-
-
JDK-8305895 Implement JEP 450: Compact Object Headers (Experimental)
-
- Resolved
-
- links to
-
Commit(master) openjdk/jdk/acdbf833
-
Review(master) openjdk/jdk/22051
(1 links to)