-
Bug
-
Resolution: Unresolved
-
P5
-
jfx24
-
windows
The flags /D_STATIC_CPPLIB and /D_DISABLE_DEPRECATE_STATIC_CPPLIB were required on Visual Studio 2010 to avoid bundling msvcp*.dll [1][2].
These flags do not work since Visual Studio 2012 [3].
These flags are initially added to common set of Visual Studio compiler flags when JavaFX is built.
BeforeJDK-8289174, these flags were then removed if JavaFX is built on Visual Studio 2010.
AfterJDK-8289174, these flags are always removed when JavaFX is built [4].
As the addition and removal of these flags are now effectively no-op, references to these flags can be removed.
[1] : https://github.com/openjdk/jfx/commit/07893972c2aeb3019b52953e1f264ec626260ba4#diff-84d1812ce010dfeff7339a1ce099c2f5aabc5195b068db589e16575ab9356b44R99
[2] : https://github.com/openjdk/jdk/commit/6f19ee9717b24d46016678f9ea770ecb40ff5d15#diff-49fea9c117888f52c338be983efd340e57588014ef247fd08047681559514fd0R571
[3] : https://mail.openjdk.org/pipermail/build-dev/2015-January/013970.html
[4] : https://github.com/openjdk/jfx/commit/a8f7850503043f616703fdfc8d0a26a00f47b7c8
These flags do not work since Visual Studio 2012 [3].
These flags are initially added to common set of Visual Studio compiler flags when JavaFX is built.
Before
After
As the addition and removal of these flags are now effectively no-op, references to these flags can be removed.
[1] : https://github.com/openjdk/jfx/commit/07893972c2aeb3019b52953e1f264ec626260ba4#diff-84d1812ce010dfeff7339a1ce099c2f5aabc5195b068db589e16575ab9356b44R99
[2] : https://github.com/openjdk/jdk/commit/6f19ee9717b24d46016678f9ea770ecb40ff5d15#diff-49fea9c117888f52c338be983efd340e57588014ef247fd08047681559514fd0R571
[3] : https://mail.openjdk.org/pipermail/build-dev/2015-January/013970.html
[4] : https://github.com/openjdk/jfx/commit/a8f7850503043f616703fdfc8d0a26a00f47b7c8
- blocks
-
JDK-8344728 ☂ Gradle build modernization
- Open
- relates to
-
JDK-8289174 JavaFX build fails on Windows when VS150COMNTOOLS is not set
- Resolved