ceil_log2 loops endlessly if the input value has the highest bit set. Either assert or return an error.
About returning an error, return type should be int. (see also log2). Then, -1 could indicate an error.
Alternatively, assert. See also log2i and log2i_graceful.
Also, gtests if possible.
About returning an error, return type should be int. (see also log2). Then, -1 could indicate an error.
Alternatively, assert. See also log2i and log2i_graceful.
Also, gtests if possible.
- duplicates
-
JDK-8340128 ceil_log2 should assert for overflow
-
- Closed
-
- relates to
-
-
- Closed
-
-
JDK-8344568 Renaming ceil_log2 to log2i_ceil
-
- Resolved
-
- links to
-
Commit(master)
openjdk/jdk/3328b4ec
-
Review(master)
openjdk/jdk/22074