-
Bug
-
Resolution: Fixed
-
P4
-
None
-
None
-
b24
A few small changes in JMX doc comments and source which can be confusing.
1
src/java.management/share/classes/javax/management/Notification.java:
Doc comments:
"network.alarm.router" is a bad example, it is mentioned three times but does not exist anywhere else.
Maybe "com.sun.management.gc.notification" is a better example.
2
src/java.management/share/classes/javax/management/remote/JMXConnectionNotification.java:
Comment on historically unknown Notification behaviour of nulls, relating to JMX 1.2.... This is unnecessary and is misleading/distracting.
162 /* We don't know whether the parent class (Notification) will
163 throw an exception if the type or source is null, because
164 JMX 1.2 doesn't specify that. So we make sure it is not
165 null, in case it would throw the wrong exception
166 (e.g. IllegalArgumentException instead of
167 NullPointerException). Likewise for the sequence number. */
168 super((String) nonNull(type),
3
src/java.management/share/classes/javax/management/MBeanServerDelegate.java
Not confusing, but an unnecessary double space typo in an comment.
34 * Represents the MBean server from the management point of view.
..which is repeated in:
src/java.management/share/classes/com/sun/jmx/mbeanserver/MBeanServerDelegateImpl.java
...in text which we make visible in MBeanInfo for "JMImplementation:type=MBeanServerDelegate":
"Represents the MBean server from the management "
1
src/java.management/share/classes/javax/management/Notification.java:
Doc comments:
"network.alarm.router" is a bad example, it is mentioned three times but does not exist anywhere else.
Maybe "com.sun.management.gc.notification" is a better example.
2
src/java.management/share/classes/javax/management/remote/JMXConnectionNotification.java:
Comment on historically unknown Notification behaviour of nulls, relating to JMX 1.2.... This is unnecessary and is misleading/distracting.
162 /* We don't know whether the parent class (Notification) will
163 throw an exception if the type or source is null, because
164 JMX 1.2 doesn't specify that. So we make sure it is not
165 null, in case it would throw the wrong exception
166 (e.g. IllegalArgumentException instead of
167 NullPointerException). Likewise for the sequence number. */
168 super((String) nonNull(type),
3
src/java.management/share/classes/javax/management/MBeanServerDelegate.java
Not confusing, but an unnecessary double space typo in an comment.
34 * Represents the MBean server from the management point of view.
..which is repeated in:
src/java.management/share/classes/com/sun/jmx/mbeanserver/MBeanServerDelegateImpl.java
...in text which we make visible in MBeanInfo for "JMImplementation:type=MBeanServerDelegate":
"Represents the MBean server from the management "
- links to
-
Commit(master) openjdk/jdk/d2b681d4
-
Review(master) openjdk/jdk/21938