-
Enhancement
-
Resolution: Unresolved
-
P4
-
24
The tests are hard to port and don't run on some of the supported platforms like PPC and S390.
In order to support a new platform, the porter needs to add a new class under:
test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForUnsupportedXXXCPU.java
and add the CPU type to:
test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForOtherCPU.java
All the GenericTestCaseForUnsupportedXXXCPU classes are identical modulo the Platform::isXXXX predicate and bit rot. The GenericTestCaseForOtherCPU always fails, and only serves as a reminder to porters that the test needs their attention.
We should clean that up, and only keep one generic test case for unsupported CPU.
In order to support a new platform, the porter needs to add a new class under:
test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForUnsupportedXXXCPU.java
and add the CPU type to:
test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForOtherCPU.java
All the GenericTestCaseForUnsupportedXXXCPU classes are identical modulo the Platform::isXXXX predicate and bit rot. The GenericTestCaseForOtherCPU always fails, and only serves as a reminder to porters that the test needs their attention.
We should clean that up, and only keep one generic test case for unsupported CPU.
- links to
-
Review(master) openjdk/jdk/22517