-
Enhancement
-
Resolution: Fixed
-
P4
-
24
-
b06
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8357208 | 21.0.9-oracle | Kavya K S | P4 | Resolved | Fixed | master |
JDK-8357217 | 17.0.17-oracle | Kavya K S | P4 | Resolved | Fixed | master |
JDK-8357216 | 11.0.29-oracle | Kavya K S | P4 | Resolved | Fixed | master |
JDK-8357417 | 8u471 | Kavya K S | P4 | Resolved | Fixed | master |
The tests are hard to port and don't run on some of the supported platforms like PPC and S390.
In order to support a new platform, the porter needs to add a new class under:
test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForUnsupportedXXXCPU.java
and add the CPU type to:
test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForOtherCPU.java
All the GenericTestCaseForUnsupportedXXXCPU classes are identical modulo the Platform::isXXXX predicate and bit rot. The GenericTestCaseForOtherCPU always fails, and only serves as a reminder to porters that the test needs their attention.
We should clean that up, and only keep one generic test case for unsupported CPU.
In order to support a new platform, the porter needs to add a new class under:
test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForUnsupportedXXXCPU.java
and add the CPU type to:
test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForOtherCPU.java
All the GenericTestCaseForUnsupportedXXXCPU classes are identical modulo the Platform::isXXXX predicate and bit rot. The GenericTestCaseForOtherCPU always fails, and only serves as a reminder to porters that the test needs their attention.
We should clean that up, and only keep one generic test case for unsupported CPU.
- backported by
-
JDK-8357208 Clean up compiler/intrinsics/sha/cli tests
-
- Resolved
-
-
JDK-8357216 Clean up compiler/intrinsics/sha/cli tests
-
- Resolved
-
-
JDK-8357217 Clean up compiler/intrinsics/sha/cli tests
-
- Resolved
-
-
JDK-8357417 Clean up compiler/intrinsics/sha/cli tests
-
- Resolved
-
- links to
-
Commit(master) openjdk/jdk/3b9732ed
-
Review(master) openjdk/jdk/22517
(1 links to)