Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8345471

Clean up compiler/intrinsics/sha/cli tests

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P4 P4
    • 25
    • 24
    • hotspot
    • b06

        The tests are hard to port and don't run on some of the supported platforms like PPC and S390.

        In order to support a new platform, the porter needs to add a new class under:
        test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForUnsupportedXXXCPU.java
        and add the CPU type to:
        test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForOtherCPU.java

        All the GenericTestCaseForUnsupportedXXXCPU classes are identical modulo the Platform::isXXXX predicate and bit rot. The GenericTestCaseForOtherCPU always fails, and only serves as a reminder to porters that the test needs their attention.

        We should clean that up, and only keep one generic test case for unsupported CPU.

              djelinski Daniel Jelinski
              djelinski Daniel Jelinski
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: