Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8346462

NotifyFramePop should return JVMTI_ERROR_DUPLICATE

XMLWordPrintable

    • Icon: CSR CSR
    • Resolution: Approved
    • Icon: P4 P4
    • 25
    • hotspot
    • None
    • behavioral
    • minimal
    • New error code JVMTI_ERROR_DUPLICATE is being specified to be returned by the NotifyFramePop function which causes a minimal compatibility risk. It is minimal because the JDWP agent implementation is already expecting this error from the NotifyFramePop.
    • Other
    • SE

      Summary

      The JVMTI NotifyFramePop should return JVMTI_ERROR_DUPLICATE.

      Problem

      Now the NotifyFramePop spec is not consistent with the SetBreakpoint spec. SetBreakpoint returns JVMTI_ERROR_DUPLICATE in a case the requested breakpoint was already requested. Also, the JDWP agent already expects the JVMTI_ERROR_DUPLICATE to be returned from NotifyFramePop.

      Solution

      The JVMTI NotifyFramePop should return JVMTI_ERROR_DUPLICATE.

      Specification

      The description of the JVMTI NotifyFramePop is updated by adding new error code JVMTI_ERROR_DUPLICATE:

      +        <error id="JVMTI_ERROR_DUPLICATE">
      +          There is already a frame pop event request at the specified depth.
      +        </error>

      This is being added for consistency with the SetBreakpoint which already returns the error code JVMTI_ERROR_DUPLICATE. Additionally, the JDWP agent is already expecting/processing this error.

            sspitsyn Serguei Spitsyn
            sspitsyn Serguei Spitsyn
            Alex Menkov, Chris Plummer
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: