-
Enhancement
-
Resolution: Fixed
-
P4
-
17, 21, 24, 25
-
b07
There is currently a build failure for x86_32 in mainline due to JDK-8346038 moving things around. The failure looks like this:
```
* For target hotspot_variant-server_libjvm_objs_c1_LinearScan_x86.o:
src/hotspot/cpu/x86/c1_LinearScan_x86.cpp: In member function 'void FpuStackAllocator::handle_op1(LIR_Op1*)':
src/hotspot/cpu/x86/c1_LinearScan_x86.cpp:652:12: error: 'class LIR_Op1' has no member named 'set_fpu_stack_size'
652 | op1->set_fpu_stack_size(sim()->stack_size());
| ^~~~~~~~~~~~~~~~~~
```
This does not warrant a fix, given the code is in deprecated x86_32 parts. But we do not need the whole `set_fpu_stack_size` infra to begin with: the last uses were removed byJDK-8143353 and JDK-8152907. So we can clean up this part for both x86_64 and x86_32 at once, and fix an easy build failure meanwhile.
```
* For target hotspot_variant-server_libjvm_objs_c1_LinearScan_x86.o:
src/hotspot/cpu/x86/c1_LinearScan_x86.cpp: In member function 'void FpuStackAllocator::handle_op1(LIR_Op1*)':
src/hotspot/cpu/x86/c1_LinearScan_x86.cpp:652:12: error: 'class LIR_Op1' has no member named 'set_fpu_stack_size'
652 | op1->set_fpu_stack_size(sim()->stack_size());
| ^~~~~~~~~~~~~~~~~~
```
This does not warrant a fix, given the code is in deprecated x86_32 parts. But we do not need the whole `set_fpu_stack_size` infra to begin with: the last uses were removed by
- relates to
-
JDK-8152907 Update for x86 tan and log10 in the math lib
-
- Resolved
-
-
JDK-8143353 update for x86 sin and cos in the math lib
-
- Resolved
-
-
JDK-8346038 [REDO] - [C1] LIR Operations with one input should be implemented as LIR_Op1
-
- Resolved
-
- links to
-
Commit(master) openjdk/jdk/c38417a8
-
Review(master) openjdk/jdk/23215