Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8349180

Remove redundant initialization in ciField constructor

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P4 P4
    • 25
    • 25
    • hotspot
    • b11

      There are duplicate assignments of ciField::_name in the first constructor.

      It looks like a merge artifact.

      Suggested fix:

      diff --git a/src/hotspot/share/ci/ciField.cpp b/src/hotspot/share/ci/ciField.cpp
      index a9fcb815a60..51dd7de540a 100644
      --- a/src/hotspot/share/ci/ciField.cpp
      +++ b/src/hotspot/share/ci/ciField.cpp
      @@ -102,8 +102,6 @@ ciField::ciField(ciInstanceKlass* klass, int index, Bytecodes::Code bc) :
           _type = ciType::make(field_type);
         }
       
      - _name = (ciSymbol*)ciEnv::current(THREAD)->get_symbol(name);
      -
         // Get the field's declared holder.
         //
         // Note: we actually create a ciInstanceKlass for this klass,

            mchevalier Marc Chevalier
            jrose John Rose
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: