Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8349934

Wrong file regex for copyright header format check in .jcheck/conf

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 25
    • 25
    • infrastructure
    • None
    • b10

      The copyright header format check was introduced in JDK-8346046. However, a user recently reported that the check doesn't catch incorrect copyright headers in this pr(https://github.com/openjdk/jdk/pull/23550).

      After investigation, I found that the issue was caused by the file regex in .jcheck/conf. There is a redundant "|" character after ".*\.jar".

      files=^(?!LICENSE|license\.txt|.*\.bin|.*\.gif|.*\.jpg|.*\.png|.*\.icon|.*\.tiff|.*\.dat|.*\.patch|.*\.wav|.*\.class|.*-header|.*\.jar|).*

      This redundant "|" prevents the regex from matching any string.

            zsong Zhao Song
            zsong Zhao Song
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: