-
Sub-task
-
Resolution: Unresolved
-
P4
-
25
From comments to PR
https://github.com/openjdk/jdk/pull/23224
" just ran a quick grep on test/hotspot/jtreg/compiler and noticed that there are a few more tests that use ProcessTools.createLimitedTestJavaProcessBuilder but don't have vm.flagless and don't seem to be covered by other JBS issues (e.g. compiler/codecache/CheckLargePages.java, compiler/onSpinWait/TestOnSpinWaitAArch64DefaultFlags.java, compiler/jvmci/TestUncaughtErrorInCompileMethod.java or compiler/jvmci/compilerToVM/GetFlagValueTest.java). Their main method runs in a new VM (@run main/othervm) but then they run other processes with ProcessTools.createLimitedTestJavaProcessBuilder . As I understand, vm flags would only affect the main method (which supposedly is not what is being tested). So, I was wondering if it made sense to mark them flagless as well anyway.
"
https://github.com/openjdk/jdk/pull/23224
" just ran a quick grep on test/hotspot/jtreg/compiler and noticed that there are a few more tests that use ProcessTools.createLimitedTestJavaProcessBuilder but don't have vm.flagless and don't seem to be covered by other JBS issues (e.g. compiler/codecache/CheckLargePages.java, compiler/onSpinWait/TestOnSpinWaitAArch64DefaultFlags.java, compiler/jvmci/TestUncaughtErrorInCompileMethod.java or compiler/jvmci/compilerToVM/GetFlagValueTest.java). Their main method runs in a new VM (@run main/othervm) but then they run other processes with ProcessTools.createLimitedTestJavaProcessBuilder . As I understand, vm flags would only affect the main method (which supposedly is not what is being tested). So, I was wondering if it made sense to mark them flagless as well anyway.
"