Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8350666

cmp-baseline builds fail after JDK-8280682

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 25
    • None
    • hotspot
    • b12

      We shouldn't store the timestamp of $JAVA_HOME/lib/modules into the CDS archive. Otherwise the contents of the CDS archive will be environment dependent (on the time of the build) and thus will not be deterministic

      Here's the fix

      $ git diff
      diff --git a/src/hotspot/share/cds/aotClassLocation.cpp b/src/hotspot/share/cds/aotClassLocation.cpp
      index c083213b933..6df2a9c1634 100644
      --- a/src/hotspot/share/cds/aotClassLocation.cpp
      +++ b/src/hotspot/share/cds/aotClassLocation.cpp
      @@ -270,7 +270,7 @@ AOTClassLocation* AOTClassLocation::allocate(JavaThread* current, const char* pa
         cs->_manifest_length = manifest_length;
         cs->_check_time = check_time;
         cs->_from_cpattr = from_cpattr;
      - cs->_timestamp = timestamp;
      + cs->_timestamp = check_time ? timestamp : 0;
         cs->_filesize = filesize;
         cs->_file_type = type;
         cs->_group = group;

            ccheung Calvin Cheung
            iklam Ioi Lam
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: