Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8350720

C2: Missed dead code elimination for useless loops with non-loop-invariant limit

XMLWordPrintable

    • x86_64
    • linux_ubuntu

      ADDITIONAL SYSTEM INFORMATION :
      # Java version
      java 23.0.2 2025-01-21
      Java(TM) SE Runtime Environment (build 23.0.2+7-58)
      Java HotSpot(TM) 64-Bit Server VM (build 23.0.2+7-58, mixed mode, sharing)

      java 21.0.6 2025-01-21 LTS
      Java(TM) SE Runtime Environment (build 21.0.6+8-LTS-188)
      Java HotSpot(TM) 64-Bit Server VM (build 21.0.6+8-LTS-188, mixed mode, sharing)

      # OS
      Ubuntu 20.04.6 LTS

      A DESCRIPTION OF THE PROBLEM :
      Consider the following JMH benchmark:

      There is an useless nested loop that exits only when `i` overflows.
      Such dead code can be removed.

      ```java
      import org.openjdk.jmh.annotations.*;
      import java.util.concurrent.TimeUnit;

      @State(Scope.Thread)
      @BenchmarkMode(Mode.AverageTime)
      @OutputTimeUnit(TimeUnit.NANOSECONDS)
      @Warmup(iterations = 5, time = 10, timeUnit = TimeUnit.SECONDS)
      @Measurement(iterations = 5, time = 10, timeUnit = TimeUnit.SECONDS)
      @Fork(3)
      public class NestedLoops {
          public static final int N = 256;

          @Benchmark
          public static void loop1() {
              double dArr[] = new double[N];
              for (int i = 0; i < 10; i++) {
                  final int tmp = i;
                  for (int k = 0; k < i; k++) {
                      i += 100000;
                  }
                  for (int p = 0; p < dArr.length; p++) {
                      dArr[p] = (p % 2 == 0) ? -3.1 + p : -3.1 - p;
                  }
                  i = tmp;
              }
          }

          @Benchmark
          public static void loop2() {
              double dArr[] = new double[N];
              for (int i = 0; i < 10; i++) {
                  final int tmp = i;
                  // for (int k = 0; k < i; k++) {
                  // i += 100000;
                  // }
                  for (int p = 0; p < dArr.length; p++) {
                      dArr[p] = (p % 2 == 0) ? -3.1 + p : -3.1 - p;
                  }
                  i = tmp;
              }
          }
      }
      ```

      Below is the results I got with JDK 23.0.2:
      ```
      Benchmark Mode Cnt Score Error Units
      NestedLoops.loop1 avgt 15 55984.459 ± 729.149 ns/op
      NestedLoops.loop2 avgt 15 1488.075 ± 109.355 ns/op
      ```

      None of the recent versions I test can do such optimization, so I report it as an enhancement.


            Unassigned Unassigned
            webbuggrp Webbug Group
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: