Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8351095

[macos] Add more jpackage tests for --mac-app-store option

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Unresolved
    • Icon: P4 P4
    • 25
    • None
    • tools
    • generic
    • os_x

      Currently, the test coverage of the "--mac-app-store" option is limited. We need to improve that.

      Current test coverage is:

      - MacAppStoreJlinkOptionsTest.java: test jlink options at [1]. Java runtime shouldn't have "bin" folder in mac app store bundles.
      - JPackageCommand.java: test ".jpackage.xml" file stores mac app store flag at [2].
      - PredefinedAppImageErrorTest.java: negative test for invalid use of "--mac-app-store" option at [3].
      - MacAppStoreRuntimeTest.java: negative test for runtime image with "bin" folder used with mac app store at [4].

      Add coverage:
       - Verify mac app store PKG doesn't have scripts.
       - `--launcher-as-service` ignored for mac app store PKG.
       - `launcher-as-service` for additional launcher ignored for mac app store PKG.

      Ideally, we should verify that mac app store PKG files can be accepted in mac app. Any ideas on how this can be automated?

      [1] https://github.com/openjdk/jdk/blob/c4b516dfe7c5a5fddd4d9c97a21f5f36bf845646/test/jdk/tools/jpackage/macosx/MacAppStoreJlinkOptionsTest.java
      [2] https://github.com/openjdk/jdk/blob/c4b516dfe7c5a5fddd4d9c97a21f5f36bf845646/test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JPackageCommand.java#L923
      [3] https://github.com/openjdk/jdk/blob/c4b516dfe7c5a5fddd4d9c97a21f5f36bf845646/test/jdk/tools/jpackage/share/PredefinedAppImageErrorTest.java#L70
      [4] https://github.com/openjdk/jdk/blob/99fb350bf65f9469c8097ddebcc6742255435a88/test/jdk/tools/jpackage/macosx/MacAppStoreRuntimeTest.java#L53

            almatvee Alexander Matveev
            asemenyuk Alexey Semenyuk
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: