Loading...

XML

Word

Printable

Negative test coverage of jpackage is quite limited.

The central location for negative tests is ErrorTest.java at [1].

Even though it performs pretty strict validation of error output from jpackage after ~~JDK-8344322~~ it doesn't have enough test cases.

Other negative tests, like [2], don't strictly validate erroneous output.

What needs to be done:
- add more test cases to ErrorTest.java
- rework other negative tests to use facilities introduced in ~~JDK-8344322~~ to validate erroneous jpackage output strictly.

[1] https://github.com/openjdk/jdk/blob/7c9a7840ea75a9a7df3f240d063e9833f535e6ec/test/jdk/tools/jpackage/share/ErrorTest.java
[2] https://github.com/openjdk/jdk/blob/caaf4098452476d981183ad4302b76b9c883a72b/test/jdk/tools/jpackage/share/MainClassTest.java#L201

causes

JDK-8352293 jpackage tests build rpm packages on Ubuntu test machines after JDK-8351372

csr for

JDK-8351446 Improve negative tests coverage of jpackage

relates to

JDK-8352275 Clean up dead code in jpackage revealed with improved negative test coverage

JDK-8352419 Test tools/jpackage/share/ErrorTest.java#id0 and #id1 fail

JDK-8344322 Improve capabilities of jpackage test lib to validate error output of jpackage

links to

Commit(master) openjdk/jdk/3aa6d62a

Review(master) openjdk/jdk/23936

(2 links to)