Negative tests coverage of jpackage is quite limited.
The central location for negative tests is ErrorTest.java at [1].
Even though it performs pretty strict validation of error output from jpackage afterJDK-8344322 it doesn't have enough test cases.
Other negative tests, like [2], don't strictly validate erroneous output.
What needs to be done:
- add more test cases to ErrorTest.java
- reowrk other negative tests to use facilities introduced inJDK-8344322 to validate erroneous jpackage output strickly.
[1] https://github.com/openjdk/jdk/blob/7c9a7840ea75a9a7df3f240d063e9833f535e6ec/test/jdk/tools/jpackage/share/ErrorTest.java
[2] https://github.com/openjdk/jdk/blob/caaf4098452476d981183ad4302b76b9c883a72b/test/jdk/tools/jpackage/share/MainClassTest.java#L201
The central location for negative tests is ErrorTest.java at [1].
Even though it performs pretty strict validation of error output from jpackage after
Other negative tests, like [2], don't strictly validate erroneous output.
What needs to be done:
- add more test cases to ErrorTest.java
- reowrk other negative tests to use facilities introduced in
[1] https://github.com/openjdk/jdk/blob/7c9a7840ea75a9a7df3f240d063e9833f535e6ec/test/jdk/tools/jpackage/share/ErrorTest.java
[2] https://github.com/openjdk/jdk/blob/caaf4098452476d981183ad4302b76b9c883a72b/test/jdk/tools/jpackage/share/MainClassTest.java#L201
- csr for
-
JDK-8351446 Improve negative tests coverage of jpackage
-
- Closed
-
- relates to
-
JDK-8344322 Improve capabilities of jpackage test lib to validate error output of jpackage
-
- Resolved
-
- links to
-
Review(master)
openjdk/jdk/23936