P4
ErrorTest.testAppContentWarning test at [1] verifies the presence of a specific warning in jpackage output when it fails signing because of faulty additional application content passed with `--app-content` CLI option.
To make jpackage fail the test sets invalid signing identity. This is the wrong way to make jpackage fail and emit the expected warning message, as jpackage should report an invalid signing identity if such is specified.
Rework the test to supply jpackage with faulty app content, e.g., a directory with the name with the dot character (.). It is known to make codesign fail. The signing configuration (a keychain and a signing identity) should be valid in this test case.
[1] https://github.com/openjdk/jdk/blob/5eee32d04b6f4c4bf0de78c295d6d6feab523ea3/test/jdk/tools/jpackage/share/ErrorTest.java#L562
To make jpackage fail the test sets invalid signing identity. This is the wrong way to make jpackage fail and emit the expected warning message, as jpackage should report an invalid signing identity if such is specified.
Rework the test to supply jpackage with faulty app content, e.g., a directory with the name with the dot character (.). It is known to make codesign fail. The signing configuration (a keychain and a signing identity) should be valid in this test case.
[1] https://github.com/openjdk/jdk/blob/5eee32d04b6f4c4bf0de78c295d6d6feab523ea3/test/jdk/tools/jpackage/share/ErrorTest.java#L562
- links to
-
Commit(master)
openjdk/jdk/10772659
-
Review(master)
openjdk/jdk/24338