-
Bug
-
Resolution: Fixed
-
P3
-
24
| Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
|---|---|---|---|---|---|---|
| JDK-8354739 | 24.0.2 | David Holmes | P3 | Resolved | Fixed | master |
The os::build_agent_function_name code contains:
#ifdef WINDOWS
else { // Need to check for drive prefix e.g. C:L.dll
if ((start = strchr(lib_name, ':')) != nullptr) {
lib_name = ++start;
}
}
#endif
but the build does not define WINDOWS, it defines _WINDOWS.
Obviously testing is lacking in this area. However it only affects agents specified using a drive letter only, with no path e.g. C:foo.dll. It is unlikely many agents get specified this way.
#ifdef WINDOWS
else { // Need to check for drive prefix e.g. C:L.dll
if ((start = strchr(lib_name, ':')) != nullptr) {
lib_name = ++start;
}
}
#endif
but the build does not define WINDOWS, it defines _WINDOWS.
Obviously testing is lacking in this area. However it only affects agents specified using a drive letter only, with no path e.g. C:foo.dll. It is unlikely many agents get specified this way.
- backported by
-
JDK-8354739 Incorrect WINDOWS ifdef in os::build_agent_function_name
-
- Resolved
-
- caused by
-
JDK-8345012 os::build_agent_function_name potentially wastes a byte when allocating the buffer
-
- Resolved
-
- links to
-
Commit(master)
openjdk/jdk24u/821c871b
-
Commit(master)
openjdk/jdk/92e52fe1
-
Review(master)
openjdk/jdk24u/193
-
Review(master)
openjdk/jdk/24641
(1 links to)