Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8355221

Get rid of unnecessary override of JDIBase.breakpointForCommunication in nsk/jdi tests

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P4 P4
    • 25
    • 11, 25
    • core-svc
    • 11
    • master

      The following tests all override the JDIBase.breakpointForCommunication() method, but no longer need too:

      vmTestbase/nsk/jdi/ClassPrepareRequest/addClassExclusionFilter/filter003.java
      vmTestbase/nsk/jdi/ClassPrepareRequest/addClassFilter_rt/filter_rt002.java
      vmTestbase/nsk/jdi/ClassPrepareRequest/addClassFilter_s/filter_s002.java
      vmTestbase/nsk/jdi/EventRequestManager/classPrepareRequests/clsprepreq002.java
      vmTestbase/nsk/jdi/EventRequestManager/methodExitRequests/methexitreq002.java
      vmTestbase/nsk/jdi/MethodEntryRequest/addClassExclusionFilter/filter002.java
      vmTestbase/nsk/jdi/MethodExitRequest/addClassExclusionFilter/filter002.java

      The override was to fix JDK-8203809. It filters out unexpected events due to system threads (namely Graal java compiler threads). However, there is now a JDIBase.breakpointForCommunication() version that does the same, so the override can be removed. The new version takes the debuggeeName argument that the override versions currently use to filter events based on it.

            cjplummer Chris Plummer
            cjplummer Chris Plummer
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: