Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8355984

Use consistent NMT names

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Unresolved
    • Icon: P4 P4
    • None
    • None
    • hotspot

      There is bunch of inconsistencies in the naming of NMT related files, classes and objects.

      I will try to compile the issues here. Then we can see if we can agree on a common naming scheme. Then we can fix it, if we want to.

      #1 Names of the NMT related locks:

      Mutex* NMTQuery_lock = nullptr;
      Mutex* NMTCompilationCostHistory_lock = nullptr;
      Mutex* NmtVirtualMemory_lock = nullptr;

      #2 Names of files:

      # cd jdk/src/hotspot/share/nmt; find .
      .
      ./memBaseline.cpp
      ./threadStackTracker.cpp
      ./memoryFileTracker.cpp
      ./vmatree.cpp
      ./nmtPreInit.hpp
      ./nmtCommon.cpp
      ./mallocTracker.hpp
      ./mallocLimit.cpp
      ./nmtDCmd.cpp
      ./nativeCallStackPrinter.hpp
      ./nmtTreap.hpp
      ./memTag.hpp
      ./nmtUsage.cpp
      ./arrayWithFreeList.hpp
      ./memLogRecorder.cpp
      ./memReporter.hpp
      ./memTracker.hpp
      ./allocationSite.hpp
      ./mallocHeader.hpp
      ./memMapPrinter.hpp
      ./nmtNativeCallStackStorage.cpp
      ./virtualMemoryTracker.hpp
      ./mallocSiteTable.cpp
      ./memTracker.inline.hpp
      ./nativeCallStackPrinter.cpp
      ./mallocTracker.inline.hpp
      ./nmtUsage.hpp
      ./memTagBitmap.hpp
      ./memTracker.cpp
      ./memReporter.cpp
      ./memLogRecorder.hpp
      ./mallocHeader.cpp
      ./memMapPrinter.cpp
      ./nmtNativeCallStackStorage.hpp
      ./mallocSiteTable.hpp
      ./virtualMemoryTracker.cpp
      ./memBaseline.hpp
      ./threadStackTracker.hpp
      ./memoryFileTracker.hpp
      ./vmatree.hpp
      ./nmtPreInit.cpp
      ./nmtCommon.hpp
      ./mallocTracker.cpp
      ./mallocLimit.hpp
      ./mallocHeader.inline.hpp
      ./nmtDCmd.hpp

      Names of the files with "nmt":

      # find . | grep -i nmt
      ./nmtPreInit.hpp
      ./nmtCommon.cpp
      ./nmtDCmd.cpp
      ./nmtTreap.hpp
      ./nmtUsage.cpp
      ./nmtNativeCallStackStorage.cpp
      ./nmtUsage.hpp
      ./nmtNativeCallStackStorage.hpp
      ./nmtPreInit.cpp
      ./nmtCommon.hpp
      ./nmtDCmd.hpp

            Unassigned Unassigned
            gziemski Gerard Ziemski
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: