-
Enhancement
-
Resolution: Unresolved
-
P4
-
None
-
25
Noticed two awkward things in current x86 interpreter profiling code.
First, we carry the implementation for counter decrements without using them. This is dead code, and can be purged.
Second, we care about overflows for 64-bit for some reason. I think this is a reminiscent of 32-bit x86 support, where we can plausibly have 32-bit counter overflow in a reasonable timeframe. But for 64-bit counter, we need tens of years of constantly bashing the counter to get it to overflow. No other profile counter update code, e.g. in C1, cares about this.
So we can save a few instructions / memory accesses on this path.
First, we carry the implementation for counter decrements without using them. This is dead code, and can be purged.
Second, we care about overflows for 64-bit for some reason. I think this is a reminiscent of 32-bit x86 support, where we can plausibly have 32-bit counter overflow in a reasonable timeframe. But for 64-bit counter, we need tens of years of constantly bashing the counter to get it to overflow. No other profile counter update code, e.g. in C1, cares about this.
So we can save a few instructions / memory accesses on this path.
- links to
-
Review(master) openjdk/jdk/25223