-
Enhancement
-
Resolution: Unresolved
-
P4
-
None
-
None
-
None
Enable --verify-exclude for hotspot.
ProblemList.txt is "clean" after:
8356866: Cleanup hotspot/jtreg/ProblemList.txt
When "8357048: Fix variable confusion in RunJtreg.gmk" is fixed, enable verification using something like:
```
diff --git a/make/RunTests.gmk b/make/RunTests.gmk
index 3c0280353a9..cb56695ecc5 100644
--- a/make/RunTests.gmk
+++ b/make/RunTests.gmk
@@ -262,6 +262,7 @@ jdk_JTREG_PROBLEM_LIST += $(TOPDIR)/test/jdk/ProblemList.txt
jaxp_JTREG_PROBLEM_LIST += $(TOPDIR)/test/jaxp/ProblemList.txt
langtools_JTREG_PROBLEM_LIST += $(TOPDIR)/test/langtools/ProblemList.txt
hotspot_JTREG_PROBLEM_LIST += $(TOPDIR)/test/hotspot/jtreg/ProblemList.txt
+hotspot_JTREG_BASIC_OPTIONS += --verify-exclude
lib-test_JTREG_PROBLEM_LIST += $(TOPDIR)/test/lib-test/ProblemList.txt
docs_JTREG_PROBLEM_LIST += $(TOPDIR)/test/docs/ProblemList.txt
@@ -702,13 +703,13 @@ endef
# Arg $3 The default value (optional)
define SetJtregValue
ifneq ($$($2), )
- $1_$2 := $$($2)
+ $1_$2 = $$($2)
else
ifneq ($$($$($1_COMPONENT)_$2), )
- $1_$2 := $$($$($1_COMPONENT)_$2)
+ $1_$2 = $$($$($1_COMPONENT)_$2)
else
ifneq ($3, )
- $1_$2 := $3
+ $1_$2 = $3
endif
endif
endif
```
ProblemList.txt is "clean" after:
8356866: Cleanup hotspot/jtreg/ProblemList.txt
When "8357048: Fix variable confusion in RunJtreg.gmk" is fixed, enable verification using something like:
```
diff --git a/make/RunTests.gmk b/make/RunTests.gmk
index 3c0280353a9..cb56695ecc5 100644
--- a/make/RunTests.gmk
+++ b/make/RunTests.gmk
@@ -262,6 +262,7 @@ jdk_JTREG_PROBLEM_LIST += $(TOPDIR)/test/jdk/ProblemList.txt
jaxp_JTREG_PROBLEM_LIST += $(TOPDIR)/test/jaxp/ProblemList.txt
langtools_JTREG_PROBLEM_LIST += $(TOPDIR)/test/langtools/ProblemList.txt
hotspot_JTREG_PROBLEM_LIST += $(TOPDIR)/test/hotspot/jtreg/ProblemList.txt
+hotspot_JTREG_BASIC_OPTIONS += --verify-exclude
lib-test_JTREG_PROBLEM_LIST += $(TOPDIR)/test/lib-test/ProblemList.txt
docs_JTREG_PROBLEM_LIST += $(TOPDIR)/test/docs/ProblemList.txt
@@ -702,13 +703,13 @@ endef
# Arg $3 The default value (optional)
define SetJtregValue
ifneq ($$($2), )
- $1_$2 := $$($2)
+ $1_$2 = $$($2)
else
ifneq ($$($$($1_COMPONENT)_$2), )
- $1_$2 := $$($$($1_COMPONENT)_$2)
+ $1_$2 = $$($$($1_COMPONENT)_$2)
else
ifneq ($3, )
- $1_$2 := $3
+ $1_$2 = $3
endif
endif
endif
```
- relates to
-
JDK-8357048 RunTest variables should always be assigned
-
- Resolved
-
-
JDK-8357051 Make Makefile result parsing handle problem list verification
-
- Open
-