Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8357829

Commented out sample limit in JfrSamplerThread::task_stacktrace

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P3 P3
    • 25
    • 25
    • hotspot
    • jfr
    • master

      SonarCloud found this today after JDK-8352251 integration. In JfrSamplerThread::task_stacktrace, there seems to be a commented-out limited stack walk:

      void JfrSamplerThread::task_stacktrace(JfrSampleRequestType type, JavaThread** last_thread) {
        const uint sample_limit = JAVA_SAMPLE == type ? 5 : 1; /// <--- UNUSED
        ...
          // while (num_samples < sample_limit) { /// <--- HERE
          while (true) {

      Is this a debugging left-over? Or is it something we actually want?

            mgronlun Markus Grönlund
            shade Aleksey Shipilev
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: