-
Type:
Bug
-
Resolution: Fixed
-
Priority:
P3
-
Affects Version/s: 25
-
Component/s: hotspot
-
b26
SonarCloud found this today after JDK-8352251 integration. In JfrSamplerThread::task_stacktrace, there seems to be a commented-out limited stack walk:
void JfrSamplerThread::task_stacktrace(JfrSampleRequestType type, JavaThread** last_thread) {
const uint sample_limit = JAVA_SAMPLE == type ? 5 : 1; /// <--- UNUSED
...
// while (num_samples < sample_limit) { /// <--- HERE
while (true) {
Is this a debugging left-over? Or is it something we actually want?
void JfrSamplerThread::task_stacktrace(JfrSampleRequestType type, JavaThread** last_thread) {
const uint sample_limit = JAVA_SAMPLE == type ? 5 : 1; /// <--- UNUSED
...
// while (num_samples < sample_limit) { /// <--- HERE
while (true) {
Is this a debugging left-over? Or is it something we actually want?
- caused by
-
JDK-8352251 Implement JEP 518: JFR Cooperative Sampling
-
- Resolved
-
- links to
-
Commit(master)
openjdk/jdk/f02190bc
-
Review(master)
openjdk/jdk/25464