Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8358107

Rollback JDK-8357299 changeset

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P3 P3
    • 25
    • 25
    • client-libs
    • None
    • 2d
    • master
    • generic
    • generic

      The patch for JDK-8357299 does not completely fix the regression it was intended to address. Instead of bailing out on overflow, it introduces additional logic around src and clip, which might lead to attempts to draw invalid source pixels.

      A test case demonstrating the issue is attached to JDK-8358103(passed on jdk22 failed on latest openjdk/jdk).

      I believe it would be better to bail out early in case of overflow than risk incorrect calculations. There are also some unresolved discussions related to that patch.

      Therefore, I propose reverting JDK-8357299 until a proper fix is available. This approach would also simplify backports, since only the patch for JDK-8358103 would need to be backported.

            serb Sergey Bylokhov
            serb Sergey Bylokhov
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: