-
Bug
-
Resolution: Unresolved
-
P4
-
24, 25, 26
-
None
The fix for JDK-8344235: Revisit SecurityManager usage in java.logging after JEP 486 and JEP 491 integration
removed use of AppContext from java/util/logging/LogManager.java
This code AppContext code used jdk.internal.access.JavaAWTAccess.java to get the AppletContext
The JavaAWTAccess was set up as a SharedSecret installed by code in the desktop module class sun/awt/AppContext.java
But now logging no longer uses it, it is obsolete.
Additionally, there are 3 logging tests that verify behaviour with AppContexts
TestUILoggerContext.java
LogManagerAppContextDeadlock.java
TestGetLoggerNPE.java
I am not sure how they all still pass, since LogManager no longer uses AppContexts.
I think it is because they just make sure LogManager doesn't break in the presence of AppContexts, rather
than explicitly verifying any partiioning.
They work by creating AppContexts by digging into the internals that I will be removing.
So I think these 3 tests need to be deleted.
They were referenced in a comment in https://bugs.openjdk.org/browse/JDK-8340326, so were on the radar, but really
they were already obsolete when the comment was written
-----
we should not remove the 3 following tests that test logging issues during Applet scenarios that have a dependency on JavaAWTAccess.
We may need to take another look at these, when the work to fully remove Applet and the remnants of Application/AppletContext are under way.
- java/util/logging/LogManagerAppContextDeadlock.java
- java/util/logging/TestGetLoggerNPE.java
- java/util/logging/TestAppletLoggerContext.java
----
removed use of AppContext from java/util/logging/LogManager.java
This code AppContext code used jdk.internal.access.JavaAWTAccess.java to get the AppletContext
The JavaAWTAccess was set up as a SharedSecret installed by code in the desktop module class sun/awt/AppContext.java
But now logging no longer uses it, it is obsolete.
Additionally, there are 3 logging tests that verify behaviour with AppContexts
TestUILoggerContext.java
LogManagerAppContextDeadlock.java
TestGetLoggerNPE.java
I am not sure how they all still pass, since LogManager no longer uses AppContexts.
I think it is because they just make sure LogManager doesn't break in the presence of AppContexts, rather
than explicitly verifying any partiioning.
They work by creating AppContexts by digging into the internals that I will be removing.
So I think these 3 tests need to be deleted.
They were referenced in a comment in https://bugs.openjdk.org/browse/JDK-8340326, so were on the radar, but really
they were already obsolete when the comment was written
-----
we should not remove the 3 following tests that test logging issues during Applet scenarios that have a dependency on JavaAWTAccess.
We may need to take another look at these, when the work to fully remove Applet and the remnants of Application/AppletContext are under way.
- java/util/logging/LogManagerAppContextDeadlock.java
- java/util/logging/TestGetLoggerNPE.java
- java/util/logging/TestAppletLoggerContext.java
----
- links to
-
Review(master) openjdk/jdk/25677