Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8359932

[macosx] Popups don't activate applet's process - unused code?

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: P4 P4
    • tbd
    • 26
    • client-libs
    • 26
    • os_x

      There are two places with tweaks for applets:

      src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java [1]
                  // Popups in applets don't activate applet's process
                  styleBits = SET(styleBits, NONACTIVATING, true);
                  styleBits = SET(styleBits, IS_POPUP, true);

      src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java [2]
                              // Popups in applets don't activate applet's process
                              CWrapper.NSWindow.orderFrontRegardless(ptr);

      These comments are removed in JDK-8359053 which removes applet support. With the applets gone, are this tweaks still needed? If not, we should remove them.

      [1] https://github.com/openjdk/jdk/blob/42d3604a31c4e5b5391468ee1d2c88c23c54c1d9/src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java#L436-L438
      [2] https://github.com/openjdk/jdk/blob/42d3604a31c4e5b5391468ee1d2c88c23c54c1d9/src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java#L717-L718

            abaya Anass Baya
            aivanov Alexey Ivanov
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: