-
Enhancement
-
Resolution: Unresolved
-
P4
-
None
While trying to benchmark src/java.base/share/classes/jdk/internal/jimage/ImageReader.java
I cannot compile code which uses APIs in either:
* java.base/jdk.internal.jimage
* java.base/jdk.internal.jrtfs
This can be fixed by adding the following lines to make/test/BuildMicrobenchmark.gmk (line 95 or so):
--add-exports java.base/jdk.internal.jimage=ALL-UNNAMED \
--add-exports java.base/jdk.internal.jrtfs=ALL-UNNAMED \
Ideally a better mechanism to determine the necessary exports by parsing the annotations in the benchmark source code, or just exporting all modules, would avoid people getting stuck on this in future (the build failure is opaque and hard to diagnose).
I cannot compile code which uses APIs in either:
* java.base/jdk.internal.jimage
* java.base/jdk.internal.jrtfs
This can be fixed by adding the following lines to make/test/BuildMicrobenchmark.gmk (line 95 or so):
--add-exports java.base/jdk.internal.jimage=ALL-UNNAMED \
--add-exports java.base/jdk.internal.jrtfs=ALL-UNNAMED \
Ideally a better mechanism to determine the necessary exports by parsing the annotations in the benchmark source code, or just exporting all modules, would avoid people getting stuck on this in future (the build failure is opaque and hard to diagnose).
- relates to
-
JDK-8361076 Add benchmark for ImageReader in preparation for Valhalla changes
-
- Open
-
- links to
-
Review(master) openjdk/jdk/26035