P4
sharedRuntimeTrans.cpp has a _WINDOWS conditional block to disable a warning and to turn off optimization of this file.
https://github.com/openjdk/jdk/blame/9d518b3213af7c60cb604138a2c4022181bb2daa/src/hotspot/share/runtime/sharedRuntimeTrans.cpp#L41-L47
The disabled warning is 4748, which is no longer documented, and seems to have not been documented since at least Visual Studio 2015. The suppression was added by JDK-8049043 (JDK 9), but it's not clear why. Seems like we can probably get rid of it.
The disabling of optimizations goes back to before the mercurial age. There have been some changes to MSVC and to this code since then. Seems like there's a good chance this is no longer needed.
https://github.com/openjdk/jdk/blame/9d518b3213af7c60cb604138a2c4022181bb2daa/src/hotspot/share/runtime/sharedRuntimeTrans.cpp#L41-L47
The disabled warning is 4748, which is no longer documented, and seems to have not been documented since at least Visual Studio 2015. The suppression was added by JDK-8049043 (JDK 9), but it's not clear why. Seems like we can probably get rid of it.
The disabling of optimizations goes back to before the mercurial age. There have been some changes to MSVC and to this code since then. Seems like there's a good chance this is no longer needed.