Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8361250

[lworld] use more IRNode regexes in valhalla IR tests

XMLWordPrintable

    • Cause Known

      Valhalla regexes for IR allocations are still old-style: they try to find a reference to the type we are interested in, then skip possible spilling, and find the call to the allocation function. This is quite brittle as already noticed (and fixed) in JDK-8314999.

      For instance, InlineTypeRegexes::ALLOC is "(.*precise compiler/valhalla/inlinetypes/MyValue.*\\R(.*(?i:mov|xorl|nop|spill).*\\R)*.*C2 Runtime new_instance" + END
      Let's instead use the IRNode::ALLOC_OF that matches on the graph and so has no spilling problems.

      Many other regexes could probably be replaced/subsumed by IRNode ones.

            mchevalier Marc Chevalier
            mchevalier Marc Chevalier
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: