Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8361259

JDK25: Backout JDK-8258229

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: P3 P3
    • 25
    • 25
    • hotspot
    • None
    • In Review

      JDK-8258229 has caused VM crashes. See JDK-8357017 for example.
      The change is incorrect for non-x86 platforms. They don't use a runtime_call for not-entrant patching at the verified entry point (VEP).

      In addition, there were concerns about the usage of NMethodState_lock. See Dean's comment in JDK-8357017:
      "This is a tricky one. I'm not really happy with the JDK-8258229 changes. It solves the problem with print_nmethod by grabbing the NMethodState_lock. This means make_not_entrant and other code that uses NMethodState_lock might block for a long time waiting for tty output. But the bigger problem is all the other uses of RelocIterator that are still susceptible to this race. I don't think we want to add NMethodState_lock to all those places."

      JDK-8358821 (in jdk26) is a better fix which doesn't have these drawbacks. We should probably backport that one to jdk25u after an appropriate stabilization time.

      I think that JDK-8258229 is not a critical issue and we can postpone fixing it by one or two jdk25u releases.

            mdoerr Martin Doerr
            mdoerr Martin Doerr
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: