The change is incorrect for non-x86 platforms. They don't use a runtime_call for not-entrant patching at the verified entry point (VEP).
In addition, there were concerns about the usage of NMethodState_lock. See Dean's comment in JDK-8357017:
"This is a tricky one. I'm not really happy with the
I think that
- relates to
-
JDK-8357017 UnexpectedDeoptimizationAllTest.java crashes in C1 during nmethod registration
-
- Open
-
-
JDK-8358821 patch_verified_entry causes problems, use nmethod entry barriers instead
-
- Resolved
-
-
JDK-8258229 Crash in nmethod::reloc_string_for
-
- Resolved
-
- links to
-
Review(jdk25) openjdk/jdk/26091