-
Enhancement
-
Resolution: Unresolved
-
P4
-
None
-
None
This is a placeholder for future work to improve the was that the newly added ImageReaderBenchmark class obtains its list of "common Java classes" to use for benchmarking.
The purpose of this list is to mimic some approximation of real world access to jimage data (instead of just reading every resource node).
Currently it is obtained via a manual process and hardcoded into the benchmark itself. This currently works and the benchmark will ignore up to some small percentage of missing entries to allow for inevitable drift of classes in the image.
Other approaches to generating the list could be:
1. Read from `build/xxx/images/jdk/lib/classlist` (though this depends on the profile used).
2. Run a java/javac job during benchmark setup to capture the list of loaded classes (e.g. for a `HelloWorld.java` compilation).
This isn't urgent however and the current approach will likely work well enough for a reasonably long time.
The purpose of this list is to mimic some approximation of real world access to jimage data (instead of just reading every resource node).
Currently it is obtained via a manual process and hardcoded into the benchmark itself. This currently works and the benchmark will ignore up to some small percentage of missing entries to allow for inevitable drift of classes in the image.
Other approaches to generating the list could be:
1. Read from `build/xxx/images/jdk/lib/classlist` (though this depends on the profile used).
2. Run a java/javac job during benchmark setup to capture the list of loaded classes (e.g. for a `HelloWorld.java` compilation).
This isn't urgent however and the current approach will likely work well enough for a reasonably long time.
- relates to
-
JDK-8361076 Add benchmark for ImageReader in preparation for Valhalla changes
-
- Resolved
-